Skip to content

Group refactoring #2838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Feb 1, 2023
Merged

Group refactoring #2838

merged 18 commits into from
Feb 1, 2023

Conversation

swilly22
Copy link
Contributor

Switching from rax to hashtable for aggregation groups lookup

@swilly22 swilly22 added enhancement x:perf Performance related issue/PR ( not affecting functionality ) action:run-benchmark Trigger CI benchmarks labels Jan 21, 2023
@swilly22 swilly22 requested a review from AviAvni January 21, 2023 13:19
@codecov
Copy link

codecov bot commented Jan 21, 2023 •
edited
Loading

Codecov Report

Base: 91.05% // Head: 90.08% // Decreases project coverage by -0.97% ⚠️

Coverage data is based on head (5d5c207) compared to base (6e459db).
Patch coverage: 45.31% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2838      +/-   ##
==========================================
- Coverage   91.05%   90.08%   -0.97%     
==========================================
  Files         269      270       +1     
  Lines       25760    26139     +379     
==========================================
+ Hits        23455    23547      +92     
- Misses       2305     2592     +287
Impacted Files Coverage Δ
src/resultset/resultset.c 100.00% <ø> (ø)
src/util/mt19937-64.c 0.00% <0.00%> (ø)
src/util/dict.c 32.50% <32.50%> (ø)
src/grouping/group.c 94.44% <92.30%> (-5.56%) ⬇️
src/execution_plan/ops/op_aggregate.c 99.36% <98.90%> (-0.64%) ⬇️
...ution_plan_build/build_pattern_comprehension_ops.c 99.03% <100.00%> (ø)
...n_plan/execution_plan_build/build_projection_ops.c 100.00% <100.00%> (ø)
src/execution_plan/ops/op.c 90.56% <100.00%> (-0.09%) ⬇️
src/execution_plan/ops/op_conditional_traverse.c 100.00% <100.00%> (ø)
src/procedures/proc_ss_paths.c 91.56% <0.00%> (+0.58%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

AviAvni
AviAvni reviewed Jan 29, 2023
View reviewed changes
@swilly22 swilly22 removed the action:run-benchmark Trigger CI benchmarks label Jan 30, 2023
swilly22
swilly22 commented Jan 30, 2023
View reviewed changes
@swilly22 swilly22 removed the x:perf Performance related issue/PR ( not affecting functionality ) label Feb 1, 2023
AviAvni
AviAvni previously approved these changes Feb 1, 2023
View reviewed changes
@swilly22 swilly22 merged commit c0bb476 into master Feb 1, 2023
@swilly22 swilly22 deleted the group-refactoring branch February 1, 2023 13:20
pnxguide pushed a commit to CMU-SPEED/RedisGraph that referenced this pull request Mar 22, 2023
@swilly22 @AviAvni
Group refactoring (RedisGraph#2838)
a68ae7f 
* adding redis dict hashtable

* aggregation group are stored in a hashtable

* fix benchmark

* fix benchmarks

* fix benchmark

* formatting

* drop aggregated record

* removed order by validation skeleton

* refactor groups

* wip

* fix leak

* removed group member

* removed group_keys

---------

Co-authored-by: Avi Avni <avi.avni@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AviAvni AviAvni AviAvni left review comments

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swilly22 @AviAvni