Skip to content

Cp 2.8.22 #2845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jan 25, 2023
Merged

Cp 2.8.22 #2845

merged 15 commits into from
Jan 25, 2023

Conversation

raz-mon
Copy link
Collaborator

@raz-mon raz-mon commented Jan 25, 2023

No description provided.

swilly22 and others added 15 commits January 25, 2023 17:01
* do not cache query params

* address PR comments

* fix leak

* fix test

* convert params to SIValues

* wip

* delay freeing of parsed params to after the query is parsed

* free parse params when freeing AST

* revert changes to ast_validations.c

* revert arithmetic_expression_construct changes

* emit an error when param value eval fails

Co-authored-by: Avi Avni <avi.avni@gmail.com>
* Add varLen property to QGEdge

* Test variable-length edge queries

* Fix spacing

* Fix test, remove direction

* Fix test

* Test zero length edge

* Init varLen in QGEdge_New()

* rename varLen to rangeLen

* Rewrite test11_range_length_edges()

* Use QGEdge_VariableLength() and QGEdge_RangeLength

* Replace QGEdge_RangeLength() by QGEdge_LengthOne()

* rename function

Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>
Co-authored-by: Avi Avni <avi.avni@gmail.com>
* fix heap remove item

* remove utf8 deps

* add test

* wip

* wip

* all unit tests pass

* heap remove element should use pointer cmp instead of cmp cb

* spaces to tabs

Co-authored-by: swilly22 <roi@redislabs.com>
Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>
* improve edge deletion

* update simple timer

* improve edge deletion perf

* fix build

* fix test

* fix test

* clean

* address review

Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Base: 92.02% // Head: 91.91% // Decreases project coverage by -0.11% ⚠️

Coverage data is based on head (d2c2360) compared to base (fa83660).
Patch coverage: 90.40% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##              2.8    #2845      +/-   ##
==========================================
- Coverage   92.02%   91.91%   -0.11%     
==========================================
  Files         264      264              
  Lines       23403    23456      +53     
==========================================
+ Hits        21536    21559      +23     
- Misses       1867     1897      +30     
Impacted Files Coverage Δ
src/arithmetic/list_funcs/list_funcs.c 98.65% <ø> (ø)
src/util/cache/cache.c 100.00% <ø> (ø)
src/util/heap.c 74.19% <74.19%> (-17.24%) ⬇️
src/arithmetic/arithmetic_expression.c 91.86% <87.87%> (-1.32%) ⬇️
src/util/cron.c 96.15% <89.47%> (-2.95%) ⬇️
src/ast/ast.c 93.80% <97.95%> (-0.08%) ⬇️
src/commands/execution_ctx.c 96.10% <100.00%> (+0.32%) ⬆️
...on_plan/execution_plan_build/build_match_op_tree.c 100.00% <100.00%> (ø)
src/execution_plan/ops/op_delete.c 99.09% <100.00%> (-0.01%) ⬇️
src/graph/entities/qg_edge.c 98.64% <100.00%> (+0.05%) ⬆️
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@AviAvni AviAvni merged commit 6435eda into 2.8 Jan 25, 2023
@AviAvni AviAvni deleted the cp-2.8.22 branch January 25, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants