Skip to content

cron abort wait if task is performed #3096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 6, 2023
Merged

Conversation

AviAvni
Copy link
Contributor

@AviAvni AviAvni commented Jun 1, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (1999e75) 90.46% compared to head (f4afbc8) 90.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3096      +/-   ##
==========================================
+ Coverage   90.46%   90.47%   +0.01%     
==========================================
  Files         288      288              
  Lines       28750    28758       +8     
==========================================
+ Hits        26008    26020      +12     
+ Misses       2742     2738       -4     
Impacted Files Coverage Δ
src/util/cron.c 99.04% <100.00%> (+1.10%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@AviAvni AviAvni merged commit 3473a6d into master Jun 6, 2023
@AviAvni AviAvni deleted the cron-abort-wait-for-task branch June 6, 2023 07:47
AviAvni added a commit that referenced this pull request Jun 7, 2023
* cron abort wait if task is performed

* fix

* fix tests

* fix
AviAvni added a commit that referenced this pull request Jun 7, 2023
* Fix ApplyConsume() (#3066)

* Use OpBase_DeepCloneRecord() in ApplyConsume()

* apply collects all LHS records

---------

Co-authored-by: swilly22 <roi@redislabs.com>

* Fix shared node detection (#3079)

* Fix share node detection

* Add tests

* bump version 2.10.11

* cron abort wait if task is performed (#3096)

* cron abort wait if task is performed

* fix

* fix tests

* fix

* fix merge

* fix merge

* fix test

---------

Co-authored-by: nafraf <nafraf@users.noreply.github.com>
Co-authored-by: swilly22 <roi@redislabs.com>
Co-authored-by: Avi Avni <avi.avni@gmail.com>
raz-mon pushed a commit that referenced this pull request Jun 22, 2023
* cron abort wait if task is performed

* fix

* fix tests

* fix
AviAvni added a commit that referenced this pull request Jun 22, 2023
* no need to activate all (#3008)

* Remove activate all (#3014)

* no need to activate all

* replicate constraint upon activation

* Remove activate all (#3015)

* no need to activate all

* replicate constraint upon activation

* test active constraint replication

* fix benchmarks (#3075)

* Fix ApplyConsume() (#3066)

* Use OpBase_DeepCloneRecord() in ApplyConsume()

* apply collects all LHS records

---------

Co-authored-by: swilly22 <roi@redislabs.com>

* Fix shared node detection (#3079)

* Fix share node detection

* Add tests

* Splitted benchmark flow into concurrent benchmark groups (#2866)

* Splitted benchmark flow into 2 concurrent ones

* Using BENCHMARK_REGEX env var introduced in redisbench-admin>=0.9.34

* Fixed non graph500 benchmarks

* Breaking down the benchmarks into 5 concurrent run-groups

* standardizing benchmark group name. include group 6 to reduce time further

* CircleCI: macOS/M1 (#2976)

* CircleCI: macOS/M1

* fixes 1

* fixes 2

* fixes 3

* fix tests

* fixes 4

* test 5

* fixes 6

* fixes 7

* fixes 8

* fixes 9

* fixes 10

* fixes 11

* fixes 12

* fixes 13

* fixes 13

---------

Co-authored-by: Avi Avni <avi.avni@gmail.com>

* Fix validation of minHops and maxHops (#3076)

* Fix validation of minHops and maxHops

* Fix _Validate_rel_pattern()

* Fix validation order and skip unsupported tests

* Fix tests

* Remove commented out code

* Simplify validation and fix test

* Create common_utils.py

* Remove duplicated '#'

* Use test function from base.py

* Fix test_bulk_insertion (#3084)

* The case ping_count==1 is valid.

* WIP: Remove call to _assert_exception()

* Test with an empty local graph

* fix db.indexes (#3094)

* update readies for rocky (#3095)

* cron abort wait if task is performed (#3096)

* cron abort wait if task is performed

* fix

* fix tests

* fix

* reduce edge size (#3099)

* reduce edge size

* reserve node id so no need to keep edge reference

* address review comment

* reserve node optional

* GRAPH.INFO QUERIES subcommand (#2919)

* wip GRAPH.INFO QUERIES

* fix

* adding more relevant parts

* more additions

* fix tests

* added more tests

* add config docs

* fix

* touchups

* refactoring

* QueryInfoStorage API removed (iterator API remained)

* refactoring wip

* wip refactor

* add waiting_queries hash-table (dict)

* notation fixes

* fix QueryInfoIterator API

* wip refactoring

* wip

* early initialization of query context

* removed interator

* wip refactor

* wip

* wip

* removed FinishedQeuryInfo and CommonQueryInfo

* fix

* compiling version

* solve deadlock

* remove compact functionality

* refactoring wip

* Remove support for Resp3

* count executing and reporting queries in one fell swoop

* wip circular buffer

* circular buffer refactor

* wip

* fix circular buffer

* fix unit tests

* fix unit tests

* added unit tests for new circular buffer API

* Address review comments

* add utilized_cache flag

* refactor tests file

* fix executing queries reading bug

* add test for CURRENT

* fix for Effects

* fix unit test

* Reset info of queries with errors

* refactoring

* refactoring

* addressing review comments

* wip refactor

* wip refactor circular buffer -> Stream

* wip refactor to Stream

* Test query info with multiple graphs

* wip refactor

* remove unused code

* resolve var redefinition

* at the moment graph.info does not expects a key

* removed redundant functionality

* revert Stream related changes

* Test query info with multiple graphs

* fixes

* refactoring in progress

* refactoring continued

* stream reporting

* removed tests

* disable assert

* acquire graph context

* move query tracking to query context

* queries log

* fix circular buffer free

* removed free callback from circular buffer

* disable query logging

* disable for debugging purpose

* shutdown cron

* alow NULL AST

* name threads

* name threads

* remove thread name

* gaurd access to graphs in keyspace

* avoid subtraction wrap around

* wrongly assigned tasks to process pool

* reduce number of logged queries

* reduce length of logged query

* clear pathos pools clean python exit

* stack base iterator

* return read pointer from circular buffer

* delay graph iterator free

* detach graph before freeing

* manage graph ref count

* remove stream upon graph rename or del

* unit test do not free graph context

* skip unit tests if memory sanitizer is enabled

* get current queries

* current and waiting queries

* partial address to PR comments

* wip fixes

* fix tests

* fix test

* fix

* fix leaks

* fix tests

* fix test

* address review

* address review

* address review

* review

* fixs

* fix test

* formatting

* formatting

* untrack cmd ctx correctly

---------

Co-authored-by: swilly22 <roi@redislabs.com>
Co-authored-by: nafraf <nafraf@gmail.com>
Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>
Co-authored-by: Avi Avni <avi.avni@gmail.com>

* Call subquery (#2926)

* checkout libcypher-parser branch supporting Call {}

* wip RO

* added validations and tests

* bump parser

* fix validations mapping size

* fix leak

* wip

* added support for RO (unit & returning) and updating (unit only), memory wip, tests wip

* removed binding of execution-plans

* wip

* fix validations

* Support Call {} being the first clause in the query

* wip

* fix

* validation fix - empty env if no imports

* update record-mapping of main plan to contain referenced entities

* adding implicit projection if there are no imports

* fix returning case

* fixed validations - projected aliases only introduced

* fixed returning non-eager case, added tests

* wip supporting eager returning subqueries

* bind project to another plan correctly

* fix validations

* wip implementing eager returning case

* wip

* test-fix

* added support for eager & returning subqueries

* fix

* fix test

* remove 'goto'

* added validation that no bound vars are returned

* added freeing mechanism to CallSubquery op

* fix leak in validations

* fix leak in subquery execution-plan construction

* fix validations

* added updating subqueries to updating clauses - order validation

* fix eager op definition

* added validations

* modified AliasModifier

* add test for ORDER BY (Sort op)

* fix eager definition, returning projection bind, importing projection search

* fixes

* fix op_cond_traverse

* Add tests: Call Subquery

* fix

* Add more tests: Call subquery

* add complex test

* merge exec-plan freeing refactor

* compress clauses in call subquery

* Test call{} compression using graph.explain()

* Fix validation of first WITH in CALL{}

* Test import of an undefined identifier

* test fix

* Bind Aggregate ops to other plans

* fixes

* review

* leak

* fix test

* add index-utlization test

* fix cond-traverse

* touchup cond-traverse

* solve leak

* free RediSearch locks in eager consumpsion

* fix leak

* support reference map construction

* tests touchup

* fix map reference construction

* fix clone exec-plan

* fix clone and construct

* add test

* Fix non-eager consume function

* fix Assertion

* wip supporting UNION

* address review comments

* fix leak

* support named paths

* add tests

* enforce simple WITH imports

* arange construction function

* add tests

* wip transforming the AST in eager & returning case

* wip transforming the AST in eager & returning case

* remove projection-addition functionality

* distinct between eager and non-eager ast-nodes

* AST transformation working

* fix leak

* fix leak

* replace clauses in subquery

* Handle addition of importing WITH

* Making ground for transforming the AST in rewrite (before exec-planning)

* touchup

* AST transformation completed

* fix deepest-finding bug

* support UNION in execution-plan construction

* wip support UNION in CallSubquery

* adding tests for Call {} with UNION

* fix

* add validation for UNION

* UNION working for eager & returning case

* fix Distinct Reset

* touchups

* fix ast-node clone

* fixes

* leak fixes and test additions

* remove macro

* fix leak

* touchups

* Add CALL{UNION} tests

* refactor ast transformation to AST-rewriting stage

* remove unused code

* touchups

* fix leak

* fix leak

* fix leak

* fix leak

* add tests

* touchups

* touchups

* addressing review comments

* Add test

* fix Join operation to not update ResultSet mapping under Call {}

* change placement of collect_aliases function

* add support for named paths in secondary UNION branches

* replace HasLocateOps

* addressing review comments

* fix

* No array for returning ops binding to outer plan

* combine branches of finding deepest ops

* remove n_branches field from call {} op struct

* add tests

* fix call {} description

* rename _find_set_deepest

* rewrite every projection only once

* fix rewriting-flow

* wrap Arguments/ArgumentLists under a connectors struct

* fix leak

* fix leak

* fix tap assertion

* fix FOREACH tap finding

* fix import error message

* fix Sort op, bind all ops between returning op and Call {} to outer-plan

* add test

* addressing review comments

* review

* review

* add tests

* add test for rewriting star projections

* fix eager definition

* fix non-returning eager record creation

* review

* fix flaky index-utilization test

* review

* introduce build_call_subquery files

* rename NewExecutionPlan

* touchup

* review fixes

* review

* review comments

* address review comments

* extract utility functions from modify -> util

* add test for reseting op_call_subquery

* fix first clause addition

* reivew

* review

* ast-rewriting touchups

* refactor comments

* remove unnecessary includes

* perform global validations on embedded call {}s before applying visitor

* fix ast-rewriting

* fix ast-rewriting

* review

* validate rewritten ast

* migrate projection creation to functions

* remove duplicate code

* review

* add WITH star before every call {}

* fix

* fix

* review + test

* add type to function argument

* review

* remove redundent clause argument

* export eager detection functions of exec-plan and ast

* fix condition for rewriting call {}

* fix projections allocation in rewrite

* touchup

* fix unwind

* fix

* touchup

* fix argumentList op, cond-traverse op, add complex test

* support star projections and imports

* support star projections in call {}

* fix leak

* fix

* fix leaks

* fix leak

* review

* merge loops

* fix leak

* leak fix attempt

* touchup

* fix leak

* replace set with replace statement

* fix leak

* addressing review comments

---------

Co-authored-by: nafraf <nafraf@gmail.com>
Co-authored-by: Avi Avni <avi.avni@gmail.com>

* fix bulk insertion test (#3106)

* fix flaky test (#3108)

* bump version 2.12.2

---------

Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>
Co-authored-by: Avi Avni <avi.avni@gmail.com>
Co-authored-by: nafraf <nafraf@users.noreply.github.com>
Co-authored-by: swilly22 <roi@redislabs.com>
Co-authored-by: filipe oliveira <filipecosta.90@gmail.com>
Co-authored-by: Rafi Einstein <raffapen@outlook.com>
Co-authored-by: Guy Korland <gkorland@gmail.com>
Co-authored-by: nafraf <nafraf@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants