fix propagate reset #3129
Merged
fix propagate reset #3129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3129 +/- ##
==========================================
- Coverage 90.85% 90.85% -0.01%
==========================================
Files 294 294
Lines 30255 30267 +12
==========================================
+ Hits 27488 27498 +10
- Misses 2767 2769 +2
☔ View full report in Codecov by Sentry. |
swilly22
suggested changes
Jul 6, 2023
swilly22
approved these changes
Jul 6, 2023
raz-mon
added a commit
that referenced
this pull request
Jul 6, 2023
* fix propogate_reset * fix * fix * fix * address review comments --------- Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>
raz-mon
added a commit
that referenced
this pull request
Jul 6, 2023
* fix propogate_reset * fix * fix * fix * address review comments --------- Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>
AviAvni
pushed a commit
that referenced
this pull request
Jul 6, 2023
* fix propagate reset (#3129) * fix propogate_reset * fix * fix * fix * address review comments --------- Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> * fix test * fix test * bump version 2.10.12 --------- Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>
swilly22
added a commit
that referenced
this pull request
Jul 17, 2023
* fix propagate reset (#3129) * fix propogate_reset * fix * fix * fix * address review comments --------- Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> * bump version 2.12.4 * require Redis version 6.2.0 or above (#3140) * require Redis version 6.2.0 or above * remove redis 6.0 from CI * ramp declares redis 6.2 as the min required redis version --------- Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the
propagate_resetmechanism to reset read operations before reseting write operations, in order to avoid writing on an indexed entity which is being read.