MOD-5869: Support mariner2 via github actions #1102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1102 +/- ##
=======================================
Coverage 79.18% 79.18%
=======================================
Files 15 15
Lines 3853 3853
=======================================
Hits 3051 3051
Misses 802 802 ☔ View full report in Codecov by Sentry. |
alonre24
reviewed
Oct 5, 2023
.install/get_redis.sh
Outdated
Comment on lines
12
to
14
| sed -ri 's/(createEnum.*enable-protected-configs.*PROTECTED_ACTION_ALLOWED)_NO/\1_YES/g' ./src/config.c | ||
| sed -ri 's/(createEnum.*enable-debug-command.*PROTECTED_ACTION_ALLOWED)_NO/\1_YES/g' ./src/config.c | ||
| sed -ri 's/(createEnum.*enable-module-command.*PROTECTED_ACTION_ALLOWED)_NO/\1_YES/g' ./src/config.c |
There was a problem hiding this comment.
Is this needed? Don't we use RLTest for that?
alonre24
reviewed
Oct 6, 2023
alonre24
reviewed
Oct 6, 2023
alonre24
reviewed
Oct 10, 2023
.github/workflows/mariner2.yml
Outdated
| steps: | ||
| - name: Install prereqs | ||
| run: | | ||
| tdnf install --noplugins --skipsignature -y ca-certificates |
There was a problem hiding this comment.
Consider haveing these in one line
.install/mariner2.sh
Outdated
Comment on lines
13
to
14
| # List installed packages | ||
| pip list |
alonre24
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support Mariner2 Linux using github actions.