Skip to content

Fix ci 2.4 #1241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 27, 2024
Merged

Fix ci 2.4 #1241

merged 4 commits into from
Aug 27, 2024

Conversation

iddm
Copy link
Collaborator

@iddm iddm commented Aug 27, 2024

No description provided.

iddm added 4 commits August 27, 2024 12:50
@iddm
Fix the CI issues. (#1231) (#1233)
7f65a66 
Fix the CI by updating the macos version.
@iddm
Fix the CI. (#1238)
bfdc6d1 
* Add alpine CI workflow. (#1230)

* Move ubuntu docker builds from CircleCI to GHA. (#1234)

* Move ubuntu docker builds from CircleCI to GHA.

* Try building Redis in parallel and use newer AWS creds

* Restrict the ubuntu docker CI only for merges/tags.
@iddm
Update the dependencies
b4c7a22
@iddm
Backport fixes from 2.6
5e07fde
@codecov Codecov
Copy link

codecov bot commented Aug 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.90%. Comparing base (f54e1c5) to head (5e07fde).
Report is 1 commits behind head on 2.4.

❗ There is a different number of reports uploaded between BASE (f54e1c5) and HEAD (5e07fde). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (f54e1c5) HEAD (5e07fde)
2 1
Additional details and impacted files 
@@             Coverage Diff             @@
##              2.4    #1241       +/-   ##
===========================================
- Coverage   79.94%   54.90%   -25.05%     
===========================================
  Files          14       14               
  Lines        3995     3989        -6     
===========================================
- Hits         3194     2190     -1004     
- Misses        801     1799      +998

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iddm
Copy link
Collaborator Author

iddm commented Aug 27, 2024

The coverage isn't related to this PR, it is the first run over a long period of time. If needs to be address, then separately.

@iddm iddm merged commit 93803a0 into 2.4 Aug 27, 2024
8 of 9 checks passed
@iddm iddm deleted the fix-ci-2.4 branch August 27, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ephraimfeldblum ephraimfeldblum ephraimfeldblum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iddm @ephraimfeldblum