Skip to content

MOD-9117 DEL key upon JSON.DEL emptying root #1336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 10, 2025
Merged

MOD-9117 DEL key upon JSON.DEL emptying root #1336

merged 3 commits into from
Apr 10, 2025

Conversation

ephraimfeldblum
Copy link
Collaborator

@ephraimfeldblum ephraimfeldblum commented Apr 10, 2025 •
edited by jira bot
Loading

@codecov Codecov
Copy link

codecov bot commented Apr 10, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 91.17647% with 6 lines in your changes missing coverage. Please review.

Project coverage is 78.17%. Comparing base (c94ee01) to head (93d9d68).
Report is 27 commits behind head on master.

Files with missing lines Patch % Lines
json_path/src/json_node.rs 62.50% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1336      +/-   ##
==========================================
- Coverage   78.37%   78.17%   -0.20%     
==========================================
  Files          15       15              
  Lines        4004     3876     -128     
==========================================
- Hits         3138     3030     -108     
+ Misses        866      846      -20

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ephraimfeldblum ephraimfeldblum merged commit f3d6cd9 into master Apr 10, 2025
18 checks passed
@ephraimfeldblum ephraimfeldblum deleted the ephraim_DEL-key-upon-JSON.DEL-emptying-root branch April 10, 2025 20:55
ephraimfeldblum added a commit that referenced this pull request Apr 14, 2025
@ephraimfeldblum
MOD-9117 DEL key upon JSON.DEL emptying root (#1336)
57b0fa0 
* DEL key upon JSON.DEL emptying root

* fix tests

(cherry picked from commit f3d6cd9)
ephraimfeldblum added a commit that referenced this pull request Apr 14, 2025
@ephraimfeldblum
MOD-9117 DEL key upon JSON.DEL emptying root (#1336) (#1337)
9368664 
* DEL key upon JSON.DEL emptying root

* fix tests

(cherry picked from commit f3d6cd9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galcohen-redislabs galcohen-redislabs galcohen-redislabs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ephraimfeldblum @galcohen-redislabs