remove Search dep #288
Merged
remove Search dep #288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove indexing examples
oshadmi
previously approved these changes
Mar 23, 2021
Comment on lines
-444
to
-447
| let schema = if raw::load_unsigned(rdb) > 0 { | ||
| Some(ValueIndex { | ||
| key: raw::load_string(rdb), | ||
| index_name: raw::load_string(rdb), |
There was a problem hiding this comment.
A bit far fetched, but is it possible that users extended the module and are writing additional module data to the db, and we should just consume (and ignore) our old schema data to avoid breaking user extension?
There was a problem hiding this comment.
Do you mean the redisearch 2.0 schema support that we just removed?
gkorland
added a commit
that referenced
this pull request
Apr 18, 2021
* remove Search dep (#288) * remove Search dep * remove search index tests * Update README.md *Remove indexing examples * remove INDEX from function doc Co-authored-by: Emmanuel Keller <74923777+emmanuelkeller@users.noreply.github.com> * update version to 1.2 Co-authored-by: Emmanuel Keller <74923777+emmanuelkeller@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.