[feature-search-json] Review before merge to master #349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* WIP Add API openKeyFromStr * WIP Align ordering of struct RedisJSONAPI_V1 in C and Rust * WIP return bulk string * WIP fix bulk string * WIP Add APIs "FromKey" and tuning
[feature-search-json] Sync with master (1)
Fixed sync from master (1)
* Update dependency redismodule-rs to be from master and fix warnings * Fix Formatting
* Update to Redis 6.2.2 (#332) * Fix json.arrappend performance (#324) * improve arr_pop, arr_insert & arr_trim performance * refactor do_json_* functions * normalize index for backward (#327) * normalize index for backward * adpat for full backward with 1.0.x * fix #318 (#333) * CircleCI: macOS and benchmark fixes (#337) * Update config.yml (#338) * Add JSON.CLEAR command (#306) * Restore optional path (default is $) for JSON.DEL * Add JSON.CLEAR * Handle JSON.CLEAR with $ path * Add JSON.CLEAR - Fix failure in test:testSetInvalidPathShouldFail * Idiomatic fixes per Gavrie review Co-authored-by: Guy Korland <gkorland@gmail.com> * Update RS_VERSIONS last promoted builds * Document flags for running tests * fix arr_pop backward to 1.0 (#345) * JSON.INSERTARR backward compatability for 1.0 (#343) * Fix JSON.INSERTARR backward compatibility with 1.0.x * Update test.py * Fix build error (use of undeclared crate or module `rawmod`) * Fix format Co-authored-by: Guy Korland <gkorland@gmail.com> Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com> Co-authored-by: tomerhekredis <72793005+tomerhekredis@users.noreply.github.com> Co-authored-by: Gavrie Philipson <gavrie@philipson.co.il> Co-authored-by: oshadmi <omer.shadmi@redislabs.com>
gkorland
suggested changes
May 6, 2021
gkorland
suggested changes
May 6, 2021
gavrie
suggested changes
May 6, 2021
src/c_api.rs
Outdated
Comment on lines
312
to
319
| Value::Bool(ref b) => return if *b { Some(1) } else { Some(0) }, | ||
| Value::Number(n) => { | ||
| if let Some(i) = n.as_i64() { | ||
| return if i != 0 { Some(1) } else { Some(0) }; | ||
| } else if let Some(f) = n.as_f64() { | ||
| return if f != 0.0 { Some(1) } else { Some(0) }; | ||
| } | ||
| } |
| //--------------------------------------------------------------------------------------------- | ||
|
|
||
| pub struct JSONApiKey<'a> { | ||
| _key: RedisKeyWritable, |
There was a problem hiding this comment.
Why is the _key field necessary if it's unused?
There was a problem hiding this comment.
It is needed for life-cycle management:
It will be dropped (and inner key will be closed) when JSONAPI_closeKey is called.
No need to use this field for other purposes.
There was a problem hiding this comment.
It would be good to document this in a comment.
There was a problem hiding this comment.
Right, will add a comment
…RedisJSON into rafi-sj-merge-to-master
gavrie
previously approved these changes
May 11, 2021
[feature-search-json] Sync with master (2)
CLang Sanitizer support in Makefile
gkorland
suggested changes
May 19, 2021
Fix per Guy's review - aux load and save
gkorland
previously approved these changes
May 19, 2021
* [skip ci] WIP - JSON CAPI - add isJSON * JSON CAPI - add isJSON (currently depend on redismodule-rs git branch) * code style change Co-authored-by: Guy Korland <gkorland@gmail.com> * Fix format * Bump Dependency to redis-module crate version 0.17.0 Co-authored-by: Guy Korland <gkorland@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.