CI benchmarks: increased number of benchmark commands to 5M min so that we run at least for >60secs #383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… at least for >60secs
rafie
approved these changes
Jun 9, 2021
filipecosta90
added a commit
that referenced
this pull request
Jun 14, 2021
… at least for >60secs (#383)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the benchmarks are running for a very small set of time. We need to address this by increasing the benchmark duration to a minimum of 60secs. Ideally, we should be running for at least 5, 10mins... but let's push forward this improvement to the quality of our data right away ( and then work on multiple benchmark runs, etc... )