Skip to content

Optional format #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 7, 2021
Merged

Optional format #400

merged 9 commits into from
Jul 7, 2021

Conversation

gkorland
Copy link
Contributor

No description provided.

@gkorland gkorland requested review from gavrie and oshadmi June 20, 2021 09:17
oshadmi
oshadmi previously approved these changes Jun 20, 2021
View reviewed changes
Copy link
Collaborator

@oshadmi oshadmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

gavrie
gavrie suggested changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@gavrie gavrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just @oshadmi 's comment.

@gkorland gkorland requested review from gavrie and oshadmi July 5, 2021 13:37
oshadmi
oshadmi previously approved these changes Jul 5, 2021
View reviewed changes
gavrie
gavrie previously approved these changes Jul 5, 2021
View reviewed changes
@gkorland gkorland dismissed stale reviews from gavrie and oshadmi via 291173d July 5, 2021 18:15
@gkorland gkorland requested review from gavrie and oshadmi July 6, 2021 05:18
oshadmi
oshadmi approved these changes Jul 6, 2021
View reviewed changes
Copy link
Collaborator

@oshadmi oshadmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@gkorland gkorland merged commit 72e8dd6 into master Jul 7, 2021
@gkorland gkorland deleted the optional_format branch July 7, 2021 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavrie gavrie gavrie approved these changes

@oshadmi oshadmi oshadmi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gkorland @gavrie @oshadmi