add multi result support of json.get #408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oshadmi
reviewed
Jun 29, 2021
Comment on lines
+836
to
+837
| env.expect("JSON.GET", "k", '$.*[0,2]').equal(['1', '3', '"c"', '"e"']) | ||
|
|
There was a problem hiding this comment.
- What would be the result of the same
GETcommand if the JSON would initially be
{"a":[1,2,3],"b":["c", "d", "e"],"c":["k"]}
(the third element would be an array but with only a single element)
Should it be['1', '3', '"c"', '"e"', "k"]? - Do we want to increase the coverage of multi-paths (more wildcards, and unions, also unions by name, not only by indices, and array slices and recursive descents)
- Do we want to also test the legacy mode? Some sanity test?
e.g.,env.expect("JSON.GET", "k", '.[*]').equal('1')
There was a problem hiding this comment.
- yep, this is the json path specification, you can use condition to filter out this result if you want (base on the array size for example)
- Yes, but not as part of this PR, this PR purpose to give initial support.
- Good point, will add it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.