change llapi to support multiple jsonpath results #417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oshadmi
reviewed
Jul 4, 2021
| @@ -407,26 +338,29 @@ pub fn json_api_get<M: Manager>( | |||
| return null(); | |||
There was a problem hiding this comment.
Do you think it would matter (slightly improve performance) if we take the optimistic approach, and assume less branch-none-taken will occur when we start by testing for the successful option that the path exists,
And only otherwise handle the failed option that the path does not exist and return null?
There was a problem hiding this comment.
This does not verify that the path exists, it verifies that the given path is a valid JSON path...
rafie
reviewed
Jul 5, 2021
rafie
previously approved these changes
Jul 6, 2021
ashtul
suggested changes
Jul 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.