Skip to content

change llapi to be declare on the initialize macro so it can be used also on hdt #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 8, 2021
Merged

change llapi to be declare on the initialize macro so it can be used also on hdt #421

merged 3 commits into from
Jul 8, 2021

Conversation

MeirShpilraien
Copy link
Collaborator

No description provided.

oshadmi
oshadmi previously approved these changes Jul 7, 2021
View reviewed changes
Copy link
Collaborator

@oshadmi oshadmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 LGTM 👀
(hoping that pre_command_function_expr that is now added to each C_API call does not incur a significant cost)

oshadmi
oshadmi approved these changes Jul 8, 2021
View reviewed changes
Copy link
Collaborator

@oshadmi oshadmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 LGTM

@MeirShpilraien MeirShpilraien merged commit f62cf86 into master Jul 8, 2021
@MeirShpilraien MeirShpilraien deleted the llapi_macro branch July 8, 2021 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oshadmi oshadmi oshadmi approved these changes

@gkorland gkorland Awaiting requested review from gkorland

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MeirShpilraien @oshadmi