Skip to content

Slice tokenizer json path #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 5, 2021
Merged

Slice tokenizer json path #442

merged 6 commits into from
Aug 5, 2021

Conversation

MeirShpilraien
Copy link
Collaborator

No description provided.

oshadmi
oshadmi previously approved these changes Aug 5, 2021
View reviewed changes
Copy link
Collaborator

@oshadmi oshadmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 LGTM (just minor comments)

@MeirShpilraien @oshadmi
Update src/commands.rs
4a730cb 
Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com>
@MeirShpilraien @oshadmi
Update src/redisjson.rs
0f6ac5c 
Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com>
oshadmi
oshadmi approved these changes Aug 5, 2021
View reviewed changes
Copy link
Collaborator

@oshadmi oshadmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@MeirShpilraien MeirShpilraien merged commit 9f1c419 into master Aug 5, 2021
@MeirShpilraien MeirShpilraien deleted the slice_tokenizer_json_path branch August 5, 2021 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oshadmi oshadmi oshadmi approved these changes

@gkorland gkorland Awaiting requested review from gkorland

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MeirShpilraien @oshadmi