Skip to content

Support multi value in arrindex #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Oct 28, 2021
Merged

Support multi value in arrindex #473

merged 13 commits into from
Oct 28, 2021

Conversation

gkorland
Copy link
Contributor

@gkorland gkorland commented Oct 13, 2021

fix #466

Multi index is not done in this PR in order to maintain backward compatibility
It could be done in a none-breaking manner by adding a new command such as ARRINDEXALL that would return all found indices and not only the first found index in each path

@oshadmi oshadmi marked this pull request as ready for review October 16, 2021 22:36
@oshadmi oshadmi changed the title Support multi value and multi index in arrindex Support multi value in arrindex Oct 17, 2021
@oshadmi oshadmi requested a review from gavrie October 21, 2021 05:57
Copy link
Contributor

@gavrie gavrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oshadmi oshadmi merged commit 552b794 into master Oct 28, 2021
@oshadmi oshadmi deleted the multi_arr_index branch October 28, 2021 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON.ARRINDEX not returning indices from multiple arrays
3 participants