Align error handling behavior #548
Conversation
| .into(), | ||
| ), | ||
| }, | ||
| _ => Ok(ObjectLen::NoneExisting), |
There was a problem hiding this comment.
Doesn't it make more sense that this is an error?
There was a problem hiding this comment.
Yes, in new behavior it is an error (see json_obj_len). This is to maintain legacy behavior.
There was a problem hiding this comment.
So why add it as part of the valid return value and not as error?
There was a problem hiding this comment.
Just for backward compatibility with V 1.0 (only with legacy path)
JSON.OBJKEYS doc1 .nowhere and JSON.OBJKEYS no_such_doc . should return null (as before)
tests/pytest/test.py
Outdated
| @@ -745,7 +745,7 @@ def testLenCommands(env): | |||
| r.assertEqual(r.execute_command('JSON.ARRLEN', 'test', '.arr'), 6) | |||
|
|
|||
| # test elements with undefined lengths | |||
| r.assertEqual(r.execute_command('JSON.ARRLEN', 'test', '.bool'), None) | |||
| r.expect('JSON.ARRLEN', 'test', '.bool').raiseError() | |||
There was a problem hiding this comment.
Let add .contains with a substring we expect to see in the error
Build was failing |
| .into(), | ||
| ), | ||
| }, | ||
| _ => Ok(ObjectLen::NoneExisting), |
There was a problem hiding this comment.
Just for backward compatibility with V 1.0 (only with legacy path)
JSON.OBJKEYS doc1 .nowhere and JSON.OBJKEYS no_such_doc . should return null (as before)
Maintain legacy behavior
And some tuning of new behavior