Skip to content

Merge ijson (#563) to 2.0 #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 15, 2021
Merged

Merge ijson (#563) to 2.0 #576

merged 7 commits into from
Dec 15, 2021

Conversation

oshadmi
Copy link
Collaborator

@oshadmi oshadmi commented Dec 14, 2021

  • initial ijson commit

  • Code arrangement

  • Return serde_json:Value support

  • Implement manager for IValue

  • Implement lasts unimplimented manager API for IValue

  • fmt fixes

  • return jsonpath library to point to generic_json_path

  • Made backend configurable on start using JSON_BACKEND module argument that can get either SERDE_JSON or IJSON, default is IJSON.

  • run tests on both backends

  • json_init -> json_init_config

  • fmt fixes

  • tests fixes

  • fmt fixes

  • disable memory test as its currently incorrect

  • review fixes

  • update redismodule-rs to 0.25

  • fix 6.0 tests

  • Skip short read test on 6.0 (too slow)

  • Skip module keyspace notification test (introduced in redis 6.2)

Co-authored-by: meir meir@redis.com
Co-authored-by: oshadmi omer.shadmi@redislabs.com
(cherry picked from commit b6a070d)

* initial ijson commit

* Code arrangement

* Return serde_json:Value support
* Implement manager for IValue

* Implement lasts unimplimented manager API for IValue

* fmt fixes

* return jsonpath library to point to generic_json_path

* Made backend configurable on start using JSON_BACKEND module argument that can get either SERDE_JSON or IJSON, default is IJSON.

* run tests on both backends

* json_init -> json_init_config

* fmt fixes

* tests fixes

* fmt fixes

* disable memory test as its currently incorrect

* review fixes

* update redismodule-rs to 0.25

* fix 6.0 tests

* Skip short read test on 6.0 (too slow)

* Skip module keyspace notification test (introduced in redis 6.2)

Co-authored-by: meir <meir@redis.com>
Co-authored-by: oshadmi <omer.shadmi@redislabs.com>
(cherry picked from commit b6a070d)
rafie
rafie previously approved these changes Dec 14, 2021
rrelledge and others added 6 commits December 14, 2021 23:50
(cherry picked from commit 57e6a87)
Co-authored-by: Rafi Einstein <rafi@redislabs.com>
(cherry picked from commit 42e6f32)
* Update freebsd.yml

(cherry picked from commit 58d6fbf)
* JSON.SET full doc benchmark extensions

* [fix] Adjusted json_vs_hashes_json.set_key_simple to use a larger keyspace range

* [fix] Fixed q5 JSON.SET test

(cherry picked from commit 3ec45da)
Bumps [mkdocs](https://github.com/mkdocs/mkdocs) from 1.1.2 to 1.2.3.
- [Release notes](https://github.com/mkdocs/mkdocs/releases)
- [Commits](mkdocs/mkdocs@1.1.2...1.2.3)

---
updated-dependencies:
- dependency-name: mkdocs
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit 91892dd)
@CLAassistant
Copy link

CLAassistant commented Dec 14, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

✅ rrelledge
✅ gkorland
✅ filipecosta90
❌ dependabot[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

@oshadmi oshadmi requested a review from rafie December 14, 2021 22:28
@rafie rafie merged commit db3329c into 2.0 Dec 15, 2021
@rafie rafie deleted the omer_merge_ijson branch December 15, 2021 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants