Return no updates when performing an NX set to an existing array element #593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Related comment |
|
@EricRabil Thank you for your fix. It looks good. We will be happy to merge it once tests are added. |
|
Awesome. I'll add tests within the next day |
|
@oshadmi tests have been added, let me know if you'd like any changes to be made to them. |
Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com>
|
@oshadmi do you have any additional changes for me to make? |
Codecov Report
@@ Coverage Diff @@
## master #593 +/- ##
==========================================
+ Coverage 82.99% 83.02% +0.03%
==========================================
Files 11 11
Lines 3116 3123 +7
==========================================
+ Hits 2586 2593 +7
Misses 530 530
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #592, although I'd like some feedback from other contributors on how I fixed it as I'm not sure if this is intentional behavior.
This does not modify the mutations made to the document, but instead stops returning an out-of-range error when doing an NX set to an array element that is, in fact, in range.