Skip to content

Enable JSON.CLEAR on numeric scalars #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 5, 2022
Merged

Conversation

oshadmi
Copy link
Collaborator

@oshadmi oshadmi commented Jan 4, 2022

  1. Enable JSON.CLEAR on numeric scalars (in addition to clearing containers (Array and Object(Map))
  2. Avoid clearing already cleared values

@oshadmi oshadmi requested a review from MeirShpilraien January 4, 2022 13:00
@codecov
Copy link

codecov bot commented Jan 4, 2022

Codecov Report

Merging #605 (231af7e) into master (9e149c7) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #605      +/-   ##
==========================================
+ Coverage   82.95%   82.99%   +0.04%     
==========================================
  Files          11       11              
  Lines        3109     3117       +8     
==========================================
+ Hits         2579     2587       +8     
  Misses        530      530              
Impacted Files Coverage Δ
src/lib.rs 95.88% <ø> (ø)
src/commands.rs 95.31% <100.00%> (+<0.01%) ⬆️
src/ivalue_manager.rs 89.48% <100.00%> (+0.05%) ⬆️
src/manager.rs 87.07% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e149c7...231af7e. Read the comment docs.

@oshadmi oshadmi requested review from gkorland and gavrie January 5, 2022 07:39
@oshadmi oshadmi changed the title Fixes for updated RedisJsonHdt (2) Enable JSON.CLEAR on numeric scalars Jan 5, 2022
@oshadmi oshadmi merged commit ad5d6f1 into master Jan 5, 2022
@oshadmi oshadmi deleted the omer_rejson_hdt_update_2 branch January 5, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants