Skip to content

null-terminate JSON string in rdb_save #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 3, 2022
Merged

Conversation

oshadmi
Copy link
Collaborator

@oshadmi oshadmi commented Feb 3, 2022

Copy link

@MeirShpilraien MeirShpilraien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the suggestion, let me know what you think.

Co-authored-by: Meir Shpilraien (Spielrein) <meir@redislabs.com>
@codecov
Copy link

codecov bot commented Feb 3, 2022

Codecov Report

Merging #643 (33bf831) into master (131f779) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #643   +/-   ##
=======================================
  Coverage   83.25%   83.26%           
=======================================
  Files          11       11           
  Lines        3231     3232    +1     
=======================================
+ Hits         2690     2691    +1     
  Misses        541      541           
Impacted Files Coverage Δ
src/redisjson.rs 79.25% <100.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 131f779...33bf831. Read the comment docs.

@oshadmi oshadmi merged commit f983b78 into master Feb 3, 2022
@oshadmi oshadmi deleted the omer_rdb_save_cstr branch February 3, 2022 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants