Skip to content

Bump dep redismodule-rs to v1.0.0 #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2022
Merged

Conversation

oshadmi
Copy link
Collaborator

@oshadmi oshadmi commented Feb 22, 2022

And clean some clippy warnings

REDISJSON_GETAPI.as_ptr() as *const c_char,
);
));
ctx.export_shared_api(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I do not understand the change, was this added to the unsafe block?

Copy link
Collaborator Author

@oshadmi oshadmi Feb 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the function export_shared_api was changed to be unsafe

Copy link
Collaborator

@MeirShpilraien MeirShpilraien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question

@oshadmi oshadmi merged commit f08d086 into master Feb 22, 2022
@oshadmi oshadmi deleted the omer_use_redismodule_1_0_0 branch February 22, 2022 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants