Skip to content

MOD-3312: Fix using the wrong manager from LLAPI #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 6, 2022

Conversation

MeirShpilraien
Copy link
Collaborator

the LLAPI was using the wrong manager to access the json data. Share code with RedisJson commands to use the right manager.

the LLAPI was using the wrong manager to access the json data.
Share code with RedisJson command to use the right manager.
@codecov
Copy link

codecov bot commented Jun 1, 2022

Codecov Report

Merging #736 (e0bf549) into master (32d21c2) will increase coverage by 2.32%.
The diff coverage is 73.52%.

@@            Coverage Diff             @@
##           master     #736      +/-   ##
==========================================
+ Coverage   83.28%   85.60%   +2.32%     
==========================================
  Files          11       11              
  Lines        3236     2931     -305     
==========================================
- Hits         2695     2509     -186     
+ Misses        541      422     -119     
Impacted Files Coverage Δ
src/c_api.rs 5.38% <5.66%> (+1.85%) ⬆️
src/manager.rs 87.30% <90.90%> (+0.02%) ⬆️
src/ivalue_manager.rs 90.49% <96.87%> (-0.11%) ⬇️
src/commands.rs 95.44% <98.87%> (-0.18%) ⬇️
src/lib.rs 86.53% <100.00%> (-8.79%) ⬇️
src/nodevisitor.rs 95.23% <100.00%> (ø)
src/redisjson.rs 79.25% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cad4bb...e0bf549. Read the comment docs.

Copy link
Collaborator

@oshadmi oshadmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@oshadmi oshadmi requested a review from rafie June 6, 2022 10:36
@oshadmi oshadmi merged commit 33111b4 into master Jun 6, 2022
@oshadmi oshadmi deleted the fix_use_of_wrong_manager_from_llapi branch June 6, 2022 20:24
@oshadmi oshadmi changed the title Fix using the wrong manager from LLAPI MOD-3312: Fix using the wrong manager from LLAPI Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants