Fix conflict on header strings.h #84
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The POSIX header is need for the functions strcasecmp and strncasecmp. But a header strings.h in RedisModuleSDK is prefered because of the -I specified. Considering the way the library is used in the SDK, it seems a better practice to specify that the header strings.h is in the rmutils directory and include RedisModuleSDK straight. Also, there is no need to have redismodule.h in the source as it is already present in the SDK directory.
|
|
|
Stale pull request message |
|
This pull request fixes 7 alerts when merging dfabfc3 into a087e7a - view on LGTM.com fixed alerts:
|
gavrie
pushed a commit
that referenced
this pull request
Apr 7, 2020
* Updated README * Separates Mac OS & Linux Run sections.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The POSIX header is needed for the functions strcasecmp and strncasecmp. But a
header strings.h in RedisModuleSDK is prefered because of the -I specified.
Considering the way the library is used in the SDK, it seems a better practice
to specify that the header strings.h is in the rmutils directory and include
RedisModuleSDK straight.
Also, there is no need to have redismodule.h in the source as it is already
present in the SDK directory.