MOD-4602: handle jsonpath filter with 3 or more operands #890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 81.44% // Head: 81.36% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #890 +/- ##
==========================================
- Coverage 81.44% 81.36% -0.09%
==========================================
Files 14 14
Lines 3865 3896 +31
==========================================
+ Hits 3148 3170 +22
- Misses 717 726 +9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Cargo.toml
Outdated
| @@ -16,6 +16,10 @@ categories = ["database-implementations"] | |||
| crate-type = ["cdylib", "rlib"] | |||
| name = "rejson" | |||
|
|
|||
| [dev-dependencies] | |||
| env_logger = "0.10.0" | |||
| redis-module = { version="1.0", features = ["experimental-api", "test"]} | |||
There was a problem hiding this comment.
Lets just make sure this will not somehow effect the final .so file itself, we need to see that the redisjson.so are still using the Redis allocator.
There was a problem hiding this comment.
I'll comment it out
MeirShpilraien
approved these changes
Dec 22, 2022
oshadmi
added a commit
that referenced
this pull request
Dec 22, 2022
* enable tracing jsonpath tests * add flow test * Evaluate all filter operands * Add tests with precedence and nesting * update spellcheck dictionary * remove redis-module from dev-dependencies (cherry picked from commit 6b30093)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #889