Skip to content

more clippy cleanups #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Feb 28, 2023
Merged

more clippy cleanups #905

merged 21 commits into from
Feb 28, 2023

Conversation

gkorland
Copy link
Contributor

No description provided.

@gkorland gkorland marked this pull request as ready for review December 29, 2022 18:25
@codecov
Copy link

codecov bot commented Dec 29, 2022 •
edited
Loading

Codecov Report

Base: 81.40% // Head: 81.49% // Increases project coverage by +0.08% 🎉

Coverage data is based on head (deff4fa) compared to base (387960e).
Patch coverage: 70.43% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #905      +/-   ##
==========================================
+ Coverage   81.40%   81.49%   +0.08%     
==========================================
  Files          15       15              
  Lines        3905     3891      -14     
==========================================
- Hits         3179     3171       -8     
+ Misses        726      720       -6
Impacted Files Coverage Δ
src/c_api.rs 8.60% <0.00%> (ø)
src/jsonpath/json_node.rs 77.05% <ø> (ø)
src/jsonpath/mod.rs 81.81% <33.33%> (-3.90%) ⬇️
src/jsonpath/json_path.rs 69.40% <41.30%> (+0.05%) ⬆️
src/commands.rs 95.67% <100.00%> (ø)
src/error.rs 73.52% <100.00%> (ø)
src/formatter.rs 100.00% <100.00%> (ø)
src/ivalue_manager.rs 90.98% <100.00%> (+0.86%) ⬆️
src/manager.rs 50.00% <100.00%> (-7.15%) ⬇️
src/serde_value_manager.rs 89.89% <100.00%> (+0.43%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gkorland gkorland requested a review from oshadmi December 30, 2022 21:17
@filipecosta90
Copy link
Contributor

filipecosta90 commented Jan 10, 2023 •
edited
Loading

Automated performance analysis summary

This comment was automatically generated given there is performance data available.

In summary:

  • Detected a total of 26 stable tests between versions.
  • Detected a total of 2 highly unstable benchmarks.
  • Detected a total of 3 improvements above the improvement water line.
  • Detected a total of 11 regressions bellow the regression water line 5.0.

You can check a comparison in detail via the grafana link

Comparison between master and gkorland-clippy-cleanup4.

Time Period from 30 days ago. (environment used: oss-standalone)

Test Case Baseline master (median obs. +- std.dev) Comparison gkorland-clippy-cleanup4 (median obs. +- std.dev) % change (higher-better) Note
json_arrappend_geojson 64504 +- 4.6% (7 datapoints) 60591 +- nan% (1 datapoints) -6.1% REGRESSION
json_get_ResultSet.totalResultsAvailable_jsonsl-yahoo2_json 121942 +- 5.9% (7 datapoints) 122693 +- nan% (1 datapoints) 0.6% waterline=5.9%. -- no change --
json_get_[0]_jsonsl-1 127379 +- 6.6% (7 datapoints) 117636 +- nan% (1 datapoints) -7.6% waterline=6.6%. REGRESSION
json_get_[7]_jsonsl-1 129026 +- 5.2% (7 datapoints) 135128 +- nan% (1 datapoints) 4.7% waterline=5.2%. potential IMPROVEMENT
json_get_[8].zero_jsonsl-1 125777 +- 4.7% (7 datapoints) 105254 +- nan% (1 datapoints) -16.3% REGRESSION
json_get_[web-app].servlet[0][servlet-name]_json-parser-0000 94104 +- 7.0% (7 datapoints) 87904 +- nan% (1 datapoints) -6.6% waterline=7.0%. potential REGRESSION
json_get_[web-app].servlet[0]_json-parser-0000 76914 +- 4.9% (7 datapoints) 76327 +- nan% (1 datapoints) -0.8% -- no change --
json_get_[web-app].servlet_json-parser-0000 72192 +- 5.3% (7 datapoints) 78423 +- nan% (1 datapoints) 8.6% waterline=5.3%. IMPROVEMENT
json_get_array_of_docs[1]_pass_100_json 113626 +- 4.5% (7 datapoints) 119039 +- nan% (1 datapoints) 4.8% potential IMPROVEMENT
json_get_array_of_docs[1]sclr_pass_100_json 113626 +- 6.7% (7 datapoints) 106945 +- nan% (1 datapoints) -5.9% waterline=6.7%. potential REGRESSION
json_get_array_of_docs_pass_100_json 120473 +- 5.5% (7 datapoints) 105813 +- nan% (1 datapoints) -12.2% waterline=5.5%. REGRESSION
json_get_fulldoc_json-parser-0000 81622 +- 4.8% (7 datapoints) 84736 +- nan% (1 datapoints) 3.8% potential IMPROVEMENT
json_get_fulldoc_jsonsl-1 90488 +- 5.3% (7 datapoints) 98030 +- nan% (1 datapoints) 8.3% waterline=5.3%. IMPROVEMENT
json_get_fulldoc_jsonsl-yahoo2_json 29188 +- 5.9% (7 datapoints) 27768 +- nan% (1 datapoints) -4.9% waterline=5.9%. potential REGRESSION
json_get_fulldoc_jsonsl-yelp_json 14276 +- 4.6% (7 datapoints) 14483 +- nan% (1 datapoints) 1.5% -- no change --
json_get_fulldoc_pass_100_json 111101 +- 4.9% (7 datapoints) 105811 +- nan% (1 datapoints) -4.8% potential REGRESSION
json_get_key_empty 132443 +- 5.5% (7 datapoints) 143877 +- nan% (1 datapoints) 8.6% waterline=5.5%. IMPROVEMENT
json_get_message.code_jsonsl-yelp_json 134225 +- 5.8% (7 datapoints) 136979 +- nan% (1 datapoints) 2.1% waterline=5.8%. -- no change --
json_get_sclr_pass_100_json 139852 +- 5.3% (7 datapoints) 142849 +- nan% (1 datapoints) 2.1% waterline=5.3%. -- no change --
json_get_sub_doc.sclr_pass_100_json 116271 +- 9.0% (7 datapoints) 124991 +- nan% (1 datapoints) 7.5% waterline=9.0%. potential IMPROVEMENT
json_get_sub_doc_pass_100_json 126576 +- 6.1% (7 datapoints) 110490 +- nan% (1 datapoints) -12.7% waterline=6.1%. REGRESSION
json_numincrby_num_1 134221 +- 7.1% (7 datapoints) 136043 +- nan% (1 datapoints) 1.4% waterline=7.1%. -- no change --
json_nummultby_num_2 134221 +- 6.8% (7 datapoints) 137923 +- nan% (1 datapoints) 2.8% waterline=6.8%. -- no change --
json_recursive_descent_with_filter_uid_issue674 183 +- 31.8% UNSTABLE (7 datapoints) 76 +- nan% (1 datapoints) -58.3% UNSTABLE (very high variance)
json_set_ResultSet.totalResultsAvailable_1_jsonsl-yahoo2_json 124217 +- 2.4% (7 datapoints) 104703 +- nan% (1 datapoints) -15.7% REGRESSION
json_set_[0]foo_jsonsl-1 116271 +- 6.0% (7 datapoints) 105257 +- nan% (1 datapoints) -9.5% waterline=6.0%. REGRESSION
json_set_[web-app].servlet[0][servlet-name]_bar_json-parser-0000 84024 +- 10.4% UNSTABLE (7 datapoints) 86571 +- nan% (1 datapoints) 3.0% UNSTABLE (very high variance)
json_set_fulldoc_api_replies_q1_google_autocomplete 43232 +- 2.6% (7 datapoints) 43944 +- nan% (1 datapoints) 1.6% -- no change --
json_set_fulldoc_api_replies_q2_gmaps_areatraffic 73791 +- 3.4% (7 datapoints) 77211 +- nan% (1 datapoints) 4.6% potential IMPROVEMENT
json_set_fulldoc_api_replies_q3_gmaps_passiveassist 39710 +- 1.5% (7 datapoints) 39909 +- nan% (1 datapoints) 0.5% -- no change --
json_set_fulldoc_api_replies_q4_gmaps_assist 96845 +- 3.5% (7 datapoints) 90490 +- nan% (1 datapoints) -6.6% REGRESSION
json_set_fulldoc_api_replies_q5_gmaps_place 1521 +- 1.0% (7 datapoints) 1546 +- nan% (1 datapoints) 1.7% -- no change --
json_set_fulldoc_pass-json-parser-0000 31937 +- 1.7% (7 datapoints) 31286 +- nan% (1 datapoints) -2.0% -- no change --
json_set_fulldoc_pass_100_json 82295 +- 3.8% (7 datapoints) 81292 +- nan% (1 datapoints) -1.2% -- no change --
json_set_fulldoc_yahoo2 8098 +- 2.0% (7 datapoints) 8020 +- nan% (1 datapoints) -1.0% -- no change --
json_set_key_empty 155029 +- 5.4% (7 datapoints) 159990 +- nan% (1 datapoints) 3.2% waterline=5.4%. potential IMPROVEMENT
json_set_message.code_1_jsonsl-yelp_json 122690 +- 6.2% (7 datapoints) 125780 +- nan% (1 datapoints) 2.5% waterline=6.2%. -- no change --
json_set_num_0 157470 +- 3.3% (7 datapoints) 158720 +- nan% (1 datapoints) 0.8% -- no change --
json_set_sclr_1_pass_100_json 124217 +- 5.1% (7 datapoints) 109883 +- nan% (1 datapoints) -11.5% waterline=5.1%. REGRESSION
json_set_sclr_pass_100_json 130709 +- 6.7% (7 datapoints) 108686 +- nan% (1 datapoints) -16.8% waterline=6.7%. REGRESSION
json_vs_hashes_hset_key_simple 161938 +- 5.5% (7 datapoints) 159355 +- nan% (1 datapoints) -1.6% waterline=5.5%. -- no change --
json_vs_hashes_json.set_key_simple 132883 +- 6.8% (7 datapoints) 112352 +- nan% (1 datapoints) -15.5% waterline=6.8%. REGRESSION

oshadmi
oshadmi reviewed Feb 20, 2023
View reviewed changes
oshadmi
oshadmi previously approved these changes Feb 20, 2023
View reviewed changes
@gkorland gkorland merged commit 5648014 into master Feb 28, 2023
@gkorland gkorland deleted the gkorland-clippy-cleanup4 branch February 28, 2023 09:49
rafie pushed a commit that referenced this pull request Apr 18, 2023
@gkorland @filipecosta90 @rafie
more clippy cleanups (#905)
9aa3525 
* clippt cleanups

* replace match with ok_or_else

* clean more warnings

* clean more code

* fix typo errors

* fix typo error

* fix typo error

* remove uneeded deref

* more cleanups

* format code

* fix code example

* two more small cleanups

* more cleanup

* remove uneeded clousre

---------

Co-authored-by: filipe oliveira <filipecosta.90@gmail.com>
(cherry picked from commit 5648014)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oshadmi oshadmi oshadmi left review comments

@MeirShpilraien MeirShpilraien Awaiting requested review from MeirShpilraien

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gkorland @filipecosta90 @oshadmi