Skip to content

break serde-json manager out to a file #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 4, 2023
Merged

Conversation

gkorland
Copy link
Contributor

@gkorland gkorland commented Jan 3, 2023

No description provided.

@gkorland gkorland marked this pull request as ready for review January 3, 2023 10:21
@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Base: 81.36% // Head: 81.36% // No change to project coverage 👍

Coverage data is based on head (395d65d) compared to base (b3ea215).
Patch coverage: 89.34% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #910   +/-   ##
=======================================
  Coverage   81.36%   81.36%           
=======================================
  Files          14       15    +1     
  Lines        3896     3896           
=======================================
  Hits         3170     3170           
  Misses        726      726           
Impacted Files Coverage Δ
src/lib.rs 86.53% <ø> (ø)
src/manager.rs 57.14% <ø> (-30.46%) ⬇️
src/redisjson.rs 82.55% <ø> (ø)
src/serde_value_manager.rs 89.34% <89.34%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@oshadmi oshadmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@gkorland gkorland merged commit 5b6a854 into master Jan 4, 2023
@gkorland gkorland deleted the gkorland-serde-manager branch January 4, 2023 10:22
rafie pushed a commit that referenced this pull request Jan 31, 2023
* break serde-json manager out to a file

* add license header

(cherry picked from commit 5b6a854)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants