-
Notifications
You must be signed in to change notification settings - Fork 332
MOD-4822: Disable recursion limit on RDB load #919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a test?
We will need to do it for hdt as well.
Codecov ReportBase: 81.36% // Head: 81.40% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #919 +/- ##
==========================================
+ Coverage 81.36% 81.40% +0.04%
==========================================
Files 15 15
Lines 3896 3905 +9
==========================================
+ Hits 3170 3179 +9
Misses 726 726
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
tests/pytest/test.py
Outdated
# RDB dump and restore the key 'doc' and check that the key is still valid | ||
dump = env.execute_command('dump', 'doc', **{NEVER_DECODE: []}) | ||
r.expect('RESTORE', 'doc1', 0, dump).ok() | ||
r.expect('JSON.GET', 'doc1', '$..z..z').equal('["a"]') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also check debug reload
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
* disable recursion limit on RDB load (cherry picked from commit 5f701d0)
No description provided.