Skip to content

Use Rust toolchain v1.66.1 for macOS/x64 due to compiler issue #923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 31, 2023
Merged

Use Rust toolchain v1.66.1 for macOS/x64 due to compiler issue #923

merged 4 commits into from
Jan 31, 2023

Conversation

rafie
Copy link
Contributor

@rafie rafie commented Jan 30, 2023

No description provided.

@rafie rafie marked this pull request as draft January 30, 2023 18:21
@codecov
Copy link

codecov bot commented Jan 30, 2023 •
edited
Loading

Codecov Report

Base: 81.40% // Head: 81.40% // No change to project coverage 👍

Coverage data is based on head (73aff1e) compared to base (ed7b5da).
Patch has no changes to coverable lines.

❗ Current head 73aff1e differs from pull request most recent head 3ff2474. Consider uploading reports for the commit 3ff2474 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #923   +/-   ##
=======================================
  Coverage   81.40%   81.40%           
=======================================
  Files          15       15           
  Lines        3905     3905           
=======================================
  Hits         3179     3179           
  Misses        726      726

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rafie rafie marked this pull request as ready for review January 30, 2023 19:02
@rafie rafie requested review from oshadmi and gkorland January 30, 2023 19:02
gkorland
gkorland previously approved these changes Jan 30, 2023
View reviewed changes
oshadmi
oshadmi previously approved these changes Jan 30, 2023
View reviewed changes
@rafie rafie dismissed stale reviews from oshadmi and gkorland via 3ff2474 January 31, 2023 06:28
@rafie rafie merged commit 9ec5c41 into master Jan 31, 2023
@rafie rafie deleted the rafi-build14 branch January 31, 2023 06:44
rafie added a commit that referenced this pull request Jan 31, 2023
@rafie
Use Rust toolchain v1.66.1 for macOS/x64 due to compiler issue (#923)
5a693f7 
(cherry picked from commit 9ec5c41)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkorland gkorland gkorland left review comments

@oshadmi oshadmi oshadmi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rafie @gkorland @oshadmi