Mediator. Minor changes; Strategy. Major changes #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleh-liskovych
commented
Jun 13, 2018
| @@ -35,7 +35,7 @@ public void collectPaymentDetails() { | |||
| System.out.print("Enter password: "); | |||
| password = READER.readLine(); | |||
| if (verify()) { | |||
| System.out.println("Data verification was successful"); | |||
| System.out.println("Data verification has succeeded"); | |||
There was a problem hiding this comment.
to match success message in Demo class
There was a problem hiding this comment.
Then it should be "has been". Can you please fix it there too?
UPD: Nevermind, I'll do it myself.
oleh-liskovych
commented
Jun 13, 2018
| @@ -59,7 +59,7 @@ public static void main(String[] args) throws IOException { | |||
| // пользовательских данных, конфигурации и прочих параметров. | |||
| if (paymentMethod.equals("1")) { | |||
| strategy = new PayByPayPal(); | |||
| } else if (paymentMethod.equals("2")) { | |||
| } else { | |||
There was a problem hiding this comment.
to prevent null pointer exception if value is not 1 or 2
oleh-liskovych
commented
Jun 13, 2018
| @@ -71,20 +71,20 @@ public static void main(String[] args) throws IOException { | |||
| // т.к. только стратегии знают какие данные им нужны для приёма | |||
| // оплаты. | |||
| order.processOrder(strategy); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
moved this code inside while loop
neochief
requested changes
Jun 14, 2018
| @@ -35,7 +35,7 @@ public void collectPaymentDetails() { | |||
| System.out.print("Enter password: "); | |||
| password = READER.readLine(); | |||
| if (verify()) { | |||
| System.out.println("Data verification was successful"); | |||
| System.out.println("Data verification has succeeded"); | |||
There was a problem hiding this comment.
Then it should be "has been". Can you please fix it there too?
UPD: Nevermind, I'll do it myself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.