Skip to content

RustPython infers global scope when scope should be unknown. #1333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cthulahoops opened this issue Aug 31, 2019 · 3 comments
Closed

RustPython infers global scope when scope should be unknown. #1333

cthulahoops opened this issue Aug 31, 2019 · 3 comments
Labels
C-bug Something isn't working

Comments

@cthulahoops
Copy link
Collaborator

RustPython

>>>>> dis.dis(compile("x", "", "eval"))                      
                 0 LoadName             (x, Global)           
                 1 ReturnValue

CPython

>>> dis.dis(compile("x", "", "eval"))
  1           0 LOAD_NAME                0 (x)
              2 RETURN_VALUE
@cthulahoops cthulahoops added C-compat A discrepancy between RustPython and CPython C-bug Something isn't working and removed C-compat A discrepancy between RustPython and CPython labels Aug 31, 2019
@cthulahoops
Copy link
Collaborator Author

(Issue reporting things incompatibility == feature?)

@cthulahoops cthulahoops mentioned this issue Aug 31, 2019
Merged
@windelbouwman windelbouwman mentioned this issue Sep 1, 2019
Merged
@coolreader18
Copy link
Member

@cthulahoops I made that label, I figured that incompatibilities represent Python features that we need to add/fix.

@dralley dralley mentioned this issue Oct 2, 2019
Closed
@dralley
Copy link
Contributor

dralley commented Dec 6, 2020

This seems like it is perhaps fixed now?

>>>>> import dis
>>>>> dis.dis(compile("x", "", "eval"))       
                 0 LoadNameAny          (0, x)
                 1 ReturnValue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dralley @cthulahoops @coolreader18