Skip to content

load_global shouldn't load outermost locals. #1332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 2, 2019
Merged

load_global shouldn't load outermost locals. #1332

merged 3 commits into from
Sep 2, 2019

Conversation

cthulahoops
Copy link
Collaborator

This leapt out at me while reviewing #1329. The code was was added recently.

@cthulahoops
Copy link
Collaborator Author

Failing due #1333

windelbouwman
windelbouwman approved these changes Sep 1, 2019
View reviewed changes
Copy link
Contributor

@windelbouwman windelbouwman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the clippy issue, this looks good to me!

@cthulahoops cthulahoops force-pushed the load_global_loading_local branch from 8429c74 to 527f3ff Compare September 2, 2019 08:35
@cthulahoops cthulahoops merged commit 814260e into master Sep 2, 2019
@youknowone youknowone deleted the load_global_loading_local branch January 15, 2020 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windelbouwman windelbouwman windelbouwman approved these changes

@palaviv palaviv Awaiting requested review from palaviv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cthulahoops @windelbouwman