Skip to content

collections.deque doesn't have __add__ method #2835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #2812
DimitrisJim opened this issue Aug 10, 2021 · 3 comments · Fixed by #2949
Closed
Tracked by #2812

collections.deque doesn't have __add__ method #2835

DimitrisJim opened this issue Aug 10, 2021 · 3 comments · Fixed by #2949
Assignees
@stromberger
Labels
good first issue Good for newcomers

Comments

@DimitrisJim
Copy link
Member

DimitrisJim commented Aug 10, 2021 •
edited
Loading

Feature

CPython:

>>> from collections import deque
>>> deque(range(3)) + deque(range(3))
deque([0, 1, 2, 0, 1, 2])

RustPython:

>>>>> from collections import deque
>>>>> deque(range(3)) + deque(range(3))
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: '+' not supported between instances of 'deque' and 'deque'
@DimitrisJim DimitrisJim mentioned this issue Aug 10, 2021
Closed
6 tasks
@DimitrisJim DimitrisJim changed the title deque.__add__ collections.deque doesn't have __add__ method Aug 10, 2021
@DimitrisJim DimitrisJim added the good first issue Good for newcomers label Aug 10, 2021
@caskercasker
Copy link

Hello @DimitrisJim I'd like to look into this issue. can you assign me?

@DimitrisJim
Copy link
Member Author

bump @caskercasker , any update on this?

@stromberger stromberger mentioned this issue Aug 23, 2021
Merged
@stromberger
Copy link
Contributor

Hey there, I tried to implement the __add__ method in #2949. This is my first issue so I appreciate every feedback that I can get.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stromberger stromberger

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added __add__ method to collections.deque stromberger/RustPython
3 participants
@stromberger @DimitrisJim @caskercasker