Skip to content

Lots of range methods left to implement #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mcon opened this issue Feb 3, 2019 · 2 comments
Closed

Lots of range methods left to implement #293

mcon opened this issue Feb 3, 2019 · 2 comments
Labels
good first issue Good for newcomers

Comments

@mcon
Copy link
Contributor

mcon commented Feb 3, 2019

Also worth noting that only the single argument overload of range is complete with the function builtin_range: vm/src/builtins.rs. This function could be easily extended to allow for multiple arguments.

Remaining methods

range . __bool__
range . __class__
range . __contains__
range . __dir__
range . __doc__
range . __format__
range . __ge__
range . __getitem__
range . __gt__
range . __init_subclass__
range . __iter__
range . __le__
range . __len__
range . __lt__
range . __reduce__
range . __reduce_ex__
range . __reversed__
range . __setattr__
range . __sizeof__
range . __subclasshook__
range . count
range . index
range . start
range . step
range . stop
@shinglyu
Copy link
Contributor

shinglyu commented Feb 4, 2019

Yes there are quite a few low hanging fruits. If you fell like working on any of them, feel free to open an issue saying "Implement range.foo()` and assign it to yourself so people won't duplicate your work.

@shinglyu shinglyu added the good first issue Good for newcomers label Feb 4, 2019
This was referenced Feb 5, 2019
Closed
Merged
@nficca nficca mentioned this issue Feb 8, 2019
Merged
This was referenced Feb 8, 2019
Merged
Merged
@RougeEtoile RougeEtoile mentioned this issue Jul 14, 2019
Closed
@youknowone
Copy link
Member

It is done except for __init__subclass__ (which will be followed up from #1346)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@youknowone @mcon @shinglyu