Skip to content

Add reversed builtin and range.__reversed__ #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 9, 2019
Merged

Add reversed builtin and range.__reversed__ #385

merged 3 commits into from
Feb 9, 2019

Conversation

OddCoincidence
Copy link
Contributor

For #293

@windelbouwman
Copy link
Contributor

@OddCoincidence thank you for your contribution, there appear to be some merge conflicts, could you take a look at those?

windelbouwman
windelbouwman requested changes Feb 9, 2019
View reviewed changes
Copy link
Contributor

@windelbouwman windelbouwman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at the merge conflicts, then we can merge this work.

@OddCoincidence
Copy link
Contributor Author

Conflicts resolved, and I also removed the direct uses of magic methods from the snippet as requested in #410

@windelbouwman windelbouwman merged commit ac37026 into RustPython:master Feb 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windelbouwman windelbouwman windelbouwman requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OddCoincidence @windelbouwman