Skip to content

[RFC] Rename derive macro to py:: prefixed #3637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
youknowone opened this issue Apr 18, 2022 · 3 comments
Open

[RFC] Rename derive macro to py:: prefixed #3637

youknowone opened this issue Apr 18, 2022 · 3 comments
Labels
RFC Request for comments

Comments

@youknowone
Copy link
Member

youknowone commented Apr 18, 2022 •
edited
Loading

Summary

  • #[pyclass] => #[py::class]
  • #[pyimpl] => #[py::class] // I think we can distinguish this from macro
  • #[pyattr] => #[py::attr]
  • #[pyfunction] => #[py::function]
  • #[pyslot] => #[py::slot]
  • #[pymethod] => #[py::method]
  • #[pyproperty] => #[py::property]

Detailed Explanation

Drawbacks, Rationale, and Alternatives

Unresolved Questions
@youknowone youknowone added the RFC Request for comments label Apr 18, 2022
@coolreader18
Copy link
Member

How would rustfmt deal with the colon?

@youknowone youknowone changed the title [RFC] Rename derive macro to py: prefixed [RFC] Rename derive macro to py:: prefixed Apr 19, 2022
@youknowone
Copy link
Member Author

I added another colon to negotiate with rustfmt

@youknowone youknowone mentioned this issue Apr 19, 2022
Draft
@youknowone
Copy link
Member Author

@coolreader18 I hope we can do this before next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
RFC Request for comments
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@youknowone @coolreader18