There are a number of things that should be addressed to get wasm32-unknown-unknown to work outside of a browser:

getrandom

Right now getrandom is defined in the Cargo.toml like this:

getrandom = { version = "0.2.6", features = ["js"] }

The js feature uses wasm_bindgen. To get rid of wasm_bindgen in this case, and to allow the consuming environment to create their own randomness, the custom feature should be used:

getrandom = { version = "0.2.6", features = ["custom"] }

I imagine some kind of feature in RustPython should allow this.

chrono

chrono currently looks like this:

chrono = { version = "0.4.19", features = ["wasmbind"] }

I'm not sure how to get chrono to work without pegging it to 0.4.19, because in 0.4.22 (which will be installed with a = peg), removing the wasmbind feature doesn't get rid of wasm_bindgen. I have this fixed in my fork like this:

chrono = "=0.4.19

A better solution should be found :)

vm/src/stdlib/time.rs

This code needs to be changed:

    #[cfg(all(target_arch = "wasm32", not(target_os = "wasi")))]
    fn _time(_vm: &VirtualMachine) -> PyResult<f64> {
        use wasm_bindgen::prelude::*;
        #[wasm_bindgen]
        extern "C" {
            type Date;
            #[wasm_bindgen(static_method_of = Date)]
            fn now() -> f64;
        }
        // Date.now returns unix time in milliseconds, we want it in seconds
        Ok(Date::now() / 1000.0)
    }

We should get rid of the hard dependency on wasm_bindgen and allow the user to hook up their own time. For example, on the Internet Computer I have an api ic_cdk::api::time that allows me to get the system time for my environment. I'll need to be able to hook that in.

vm/src/vm/vm_object.rs

This code should not depend directly on wasm_bindgen, in my fork I commented most of it out. I'm not sure how it should be done:

        #[cfg(all(target_arch = "wasm32", not(target_os = "wasi")))]
        {
            use wasm_bindgen::prelude::*;
            #[wasm_bindgen]
            extern "C" {
                #[wasm_bindgen(js_namespace = console)]
                fn error(s: &str);
            }
            let mut s = String::new();
            self.write_exception(&mut s, &exc).unwrap();
            error(&s);
            panic!("{}; exception backtrace above", msg)
        }

I just changed it to:

panic!("{}", msg)

Remove #[wasm_bindgen] under vm crate #4136

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Remove `#[wasm_bindgen]` under vm crate #4136