Skip to content

sys.platform of wasm32-wasi build to wasi instead of unknown #4539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #4537
, #4564
...
youknowone opened this issue Feb 21, 2023 · 2 comments · Fixed by #4576
Closed
Tracked by #4537
, #4564
...

sys.platform of wasm32-wasi build to wasi instead of unknown #4539

youknowone opened this issue Feb 21, 2023 · 2 comments · Fixed by #4576
Assignees
@jhowww
Labels
A-stdlib C-compat A discrepancy between RustPython and CPython good first issue Good for newcomers O-wasm

Comments

@youknowone
Copy link
Member

youknowone commented Feb 21, 2023 •
edited
Loading

CPython part: https://github.com/RustPython/RustPython/pull/4537/files#diff-d925268c057737ba320c489ca302fd5125f14840d22e50cfe226bdb5bb88ba8dR517-R518

actual:

$ cargo build --release --target wasm32-wasi --no-default-features --features stdlib,encodings,threading,freeze-stdlib
$ wasmer run --env RUST_BACKTRACE=full --dir . target/wasm32-wasi/release/rustpython.wasm -- -c 'import sys; print(sys.platform)'
unknown

expected:

wasi
@youknowone youknowone changed the title Check out wasi build compatible with CPython wasi build Check our wasi build compatible with CPython wasi build Feb 21, 2023
@youknowone youknowone mentioned this issue Feb 21, 2023
Merged
5 tasks
@youknowone
Copy link
Member Author

@jhowww how about this one?

@youknowone youknowone changed the title Check our wasi build compatible with CPython wasi build sys.platform of wasm32-wasi build to wasi instead of unknown Feb 21, 2023
@youknowone youknowone added good first issue Good for newcomers C-compat A discrepancy between RustPython and CPython O-wasm A-stdlib labels Feb 21, 2023
@jhowww
Copy link
Contributor

jhowww commented Feb 21, 2023

Thanks! I can give it a shot.

@youknowone youknowone mentioned this issue Feb 24, 2023
Closed
@jhowww jhowww mentioned this issue Feb 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhowww jhowww

Labels
A-stdlib C-compat A discrepancy between RustPython and CPython good first issue Good for newcomers O-wasm
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add wasm32-wasi as wasi in sys.platform jhowww/RustPython
2 participants
@youknowone @jhowww