Skip to content

Support locale for FormatSpec n #4613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
youknowone opened this issue Mar 2, 2023 · 2 comments
Open

Support locale for FormatSpec n #4613

youknowone opened this issue Mar 2, 2023 · 2 comments
Labels
A-stdlib C-bug Something isn't working C-compat A discrepancy between RustPython and CPython

Comments

@youknowone
Copy link
Member

youknowone commented Mar 2, 2023

See #4609 to check related test and place to edit.

I marked it as good first issue because it is not deeply coupled to RustPython core.
But without knowledge of locale and number formatting, it will not be very easy.

@youknowone youknowone added C-bug Something isn't working C-compat A discrepancy between RustPython and CPython A-stdlib good first issue Good for newcomers labels Mar 2, 2023
@glitchdoescode
Copy link

Hey i would like to contriubute to this issue, can you send me more details regarding the issue, and help me a bit to initiate with the issue ?

@youknowone youknowone removed the good first issue Good for newcomers label Sep 8, 2024
@youknowone
Copy link
Member Author

@glitchxxx0 Hi! RustPython codebase is changed a lot since #4609 is written.

Linux machine is recommended to run tests.

  1. Remove @unittest.expectedFailure from the test https://github.com/RustPython/RustPython/blob/main/Lib/test/test_types.py#L424-L425
  2. rustpython-format is now placed in different repository. This task will be multi-repository tasks. The relocated source code is here: https://github.com/RustPython/Parser/blob/main/format/src/format.rs
  3. FormatSpec::format_int have to take locale information from somewhere out of the format, which can be used for n format. Because FormatSpec or rustpython-format is not expected to know about platform-specific locale handling, there must be.. something to do it.

Because many things are changed, I don't think this is a good first issue anymore.

Since everybody has different view for problems, sharing everything about the issue is not easy. Please share me any blocking issues what makes you stuck or not to dive in coding. I'll try to catch what's missing for you.

Thank you for visiting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-stdlib C-bug Something isn't working C-compat A discrepancy between RustPython and CPython
Projects
None yet
Development

No branches or pull requests

2 participants