Skip to content

Fix broken mac build #4995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
youknowone opened this issue Jun 8, 2023 · 4 comments
Closed

Fix broken mac build #4995

youknowone opened this issue Jun 8, 2023 · 4 comments

Comments

@youknowone
Copy link
Member

First broken build: 7a3f965
@DimitrisJim
Copy link
Member

DimitrisJim commented Jun 8, 2023 •
edited
Loading

do we set RUST_BACKTRACE in the tests? Might be useful since locally you can't repro so the logs are the only thing we're going with.

edit: we do set it.

This was referenced Jun 10, 2023
Merged
Open
@youknowone
Copy link
Member Author

By testing from #5008, it came from CI changes, not the code changes.

@DimitrisJim
Copy link
Member

This still bugs me, the tests on the PR passed, when merged to main they started failing. What CI changes caused this?

@youknowone
Copy link
Member Author

No idea at all. I also experienced locally unreproducible error in #4733
I hope to know how can I have exactly same environment to CI macOS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@youknowone @DimitrisJim