Fix memoryview.obj misimplementation. #1017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The memoryview skeleton did not correctly assign the "obj" attribute; The "obj" attribute was assigned to the memoryview class and not the memryview object, leading to a funny bug that can be reproduced as follows: ```python m1 = memoryview(b'1234') m2 = memoryview(b'abcd') print(m1.obj) ``` the result would be the value inside `m2` instead that of `m1`
Codecov Report
@@ Coverage Diff @@
## master #1017 +/- ##
==========================================
- Coverage 64.58% 64.57% -0.01%
==========================================
Files 96 96
Lines 16891 16894 +3
Branches 3775 3774 -1
==========================================
+ Hits 10909 10910 +1
- Misses 3426 3429 +3
+ Partials 2556 2555 -1
Continue to review full report at Codecov.
|
|
Thanks for contributing! This change looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The memoryview skeleton did not correctly assign the "obj" attribute;
The "obj" attribute was assigned to the memoryview class and not the memryview object,
leading to a funny bug that can be reproduced as follows:
the result would be the value inside
m2instead that ofm1