Enable clippy in CI #1114
Merged
Enable clippy in CI #1114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5cc3e60 to
de9a917
Compare
| @@ -39,6 +39,17 @@ matrix: | |||
| env: | |||
| - JOBCACHE=3 | |||
|
|
|||
| - name: Lint code with clippy | |||
There was a problem hiding this comment.
Does it make sense to combine the rustfmt check with this check to reduce the amount of different jobs? We could add cargo clippy --all to the rustfmt job above.
There was a problem hiding this comment.
Is there a way to make them appear in a different rows in the Travis output? I'd like to spare user from looking inside the Travis row to see what's going on. He sees that formatter failed, goes to his own terminal, runs it, creates new commit.
There was a problem hiding this comment.
Okay, that sounds fair to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.