complex: Fix hash function to work correctly #1123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b240d02 to
3078468
Compare
silmeth
reviewed
Jul 9, 2019
Currently, hash(3.1-4.2j) or hash(3.1+4.2j) is crashed due to overflow error on RustPython. This patch will fix this issue.
3078468 to
d349d25
Compare
|
@silmeth I've updated the PR. PTAL |
coolreader18
approved these changes
Jul 10, 2019
| @@ -254,7 +255,7 @@ impl PyComplex { | |||
| fn hash(&self, _vm: &VirtualMachine) -> pyhash::PyHash { | |||
| let re_hash = pyhash::hash_float(self.value.re); | |||
| let im_hash = pyhash::hash_float(self.value.im); | |||
|
|
|||
| re_hash + im_hash * pyhash::IMAG | |||
| let ret = Wrapping(re_hash) + Wrapping(im_hash) * Wrapping(pyhash::IMAG); | |||
There was a problem hiding this comment.
Interesting stuff, this wrapping! Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, hash(3.1-4.2j) or hash(3.1+4.2j) is crashed due to
overflow error on RustPython.
This patch will fix this issue.