Skip to content

Cover up bare trait objects with a dyn #1129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2019
Merged

Cover up bare trait objects with a dyn #1129

merged 1 commit into from
Jul 10, 2019

Conversation

coolreader18
Copy link
Member

No description provided.

@windelbouwman
Copy link
Contributor

What does this change do? What is dyn? Could you explain a bit to me?

@coolreader18
Copy link
Member Author

coolreader18 commented Jul 10, 2019 •
edited
Loading

The older syntax for trait object types was just the bare trait name, e.g. Box<std::any::Any>, vs the newer one which prefixes the trait name with the dyn keyword (Box<dyn std::any::Any>). They have the same meaning, but bare trait objects are already deprecated on nightly (with a warning) so I figured I'd switch our uses to the new version.

@windelbouwman windelbouwman merged commit b2c515c into master Jul 10, 2019
@coolreader18 coolreader18 deleted the coolreader18/no-bare-trait-objects branch July 10, 2019 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coolreader18 @windelbouwman