Skip to content

Implement several methods - os module #1191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 31, 2019
Merged

Implement several methods - os module #1191

merged 2 commits into from
Jul 31, 2019

Conversation

mpajkowski
Copy link
Contributor

os.getpid [RUST STD]
os.getegid [UNIX]
os.getgid [UNIX]
os.getsid [UNIX]
os.getuid [UNIX]
os.geteuid [UNIX]
os.getppid [UNIX]
os.getpgid [UNIX]
os.setgid [UNIX]
os.setegid [UNIX]
os.setpgid [UNIX]
os.setuid [UNIX]
os.seteuid [UNIX]

os.getpid  [RUST STD]
os.getegid [UNIX]
os.getgid  [UNIX]
os.getsid  [UNIX]
os.getuid  [UNIX]
os.geteuid [UNIX]
os.getppid [UNIX]
os.getpgid [UNIX]
os.setgid  [UNIX]
os.setegid [UNIX]
os.setpgid [UNIX]
os.setuid  [UNIX]
os.seteuid [UNIX]
@mpajkowski
Copy link
Contributor Author

Hello,

I implemented several methods for os module - mostly UNIX-available ones. Right now I am using nix crate and I would kindly ask for feedback if adding this dependency to Cargo.toml is a way to go.

@windelbouwman windelbouwman requested a review from palaviv July 31, 2019 11:16
@windelbouwman
Copy link
Contributor

@mpajkowski I think the nix crate is good. @palaviv used the same crate for implementing the signal module in #1189 .

@coolreader18 coolreader18 merged commit 13d0c07 into RustPython:master Jul 31, 2019
@mpajkowski mpajkowski deleted the os_module branch July 31, 2019 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants