Fix panics with int() #1290
Merged
Fix panics with int() #1290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -97,14 +97,40 @@ | |||
| assert -10 // -4 == 2 | |||
|
|
|||
| assert int() == 0 | |||
| assert int("101", 2) == 5 | |||
| assert int("101", base=2) == 5 | |||
There was a problem hiding this comment.
Its good to keep this check with an explicit base given.
There was a problem hiding this comment.
ok, I'll fix it in a moment
|
@mpajkowski nice job! |
seeeturtle
suggested changes
Aug 18, 2019
+ add automatic radix detection based on given literal if optional arg base is set to 0 (CPython behavior) + tolerate underscore separators
+ Add tests covering those changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1228 issue