Skip to content

Fix symtable scan_expression not to mark sequence as Load #1328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 1, 2019

Conversation

youknowone
Copy link
Member

No description provided.

@youknowone youknowone force-pushed the symtable-sequence-store branch from 423aa6c to b73f3d6 Compare August 30, 2019 15:25
@youknowone
Copy link
Member Author

youknowone commented Aug 30, 2019

@windelbouwman
Copy link
Contributor

@windelbouwman the crawl result is not very same https://gist.github.com/youknowone/def929a322d21535c9cf99117072f61a

Child table here? https://gist.github.com/youknowone/def929a322d21535c9cf99117072f61a#file-out-diff-L309

We need to create symboltables for list/set/tuple/dict comprehensions as well. Comprehensions are implemented as functions, so they have their own symbol table.

The other issue is that the ast module does not create proper nodes for the elements in the comprehensions. This must be added as well.

Do you want to implement this change in this pull request? It can be quite useful!

@windelbouwman windelbouwman merged commit ba9736b into RustPython:master Sep 1, 2019
@windelbouwman
Copy link
Contributor

@youknowone I implemented the comprehension scopes for generators, see #1336

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants