Implement itertools.accumulate #1372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11f19c3 to
708fd9b
Compare
coolreader18
approved these changes
Sep 13, 2019
vm/src/stdlib/itertools.rs
Outdated
| binop: binop.unwrap_or_else(|| vm.get_none()), | ||
| acc_value: RefCell::from(vm.get_none()), | ||
| } | ||
| .into_ref(vm) |
There was a problem hiding this comment.
You should use into_ref_with_type() here and make the return type PyResult<PyItertoolsAccumulate>.
There was a problem hiding this comment.
I see, thanks for pointing out!
vm/src/stdlib/itertools.rs
Outdated
| struct PyItertoolsAccumulate { | ||
| iterable: PyObjectRef, | ||
| binop: PyObjectRef, | ||
| acc_value: RefCell<PyObjectRef>, |
There was a problem hiding this comment.
Maybe have this as an Option rather than using None as "not yet started iterating", because the binop function could return None.
There was a problem hiding this comment.
Right, this wasn't carefully thought out.
corona10
approved these changes
Sep 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1361
This is an implementation of the Python standard library function
itertools.accumulate. I also included a couple of very basic tests.