Assignment #138
Merged
Assignment #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Ok(ast::LocatedStatement { | ||
| location: ast::Location::new(1, 1), | ||
| node: ast::Statement::Assign { | ||
| targets: vec![ast::Expression::Tuple { |
There was a problem hiding this comment.
What kind of expressions are allowed at the left hand side (LHS)? Is it tuples, names only? Or are lists also allowed?
There was a problem hiding this comment.
Tuples, lists, names, attributes, indices, slices.
I'm not sure if there are any others.
| @@ -1045,6 +1046,19 @@ impl VirtualMachine { | |||
| } | |||
| None | |||
| } | |||
| bytecode::Instruction::UnpackSequence { size } => { | |||
| let value = self.pop_value(); | |||
|
|
|||
There was a problem hiding this comment.
Should we add a type check here?
There was a problem hiding this comment.
The full implementation requires __iter__, which you've just started to provide. I'll extend this to call that.
|
Nice job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First steps in this. Need to generalise to support other iterators not just tuples.