Add a hash field to PyString á la CPython, make PyString.value private #1387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24dc622 to
0def37d
Compare
palaviv
approved these changes
Sep 21, 2019
palaviv
reviewed
Sep 21, 2019
vm/src/stdlib/socket.rs
Outdated
| host: PyStringRef::try_from_object(vm, tuple.elements[0].clone())? | ||
| .value | ||
| .to_string(), | ||
| host: vm.to_pystr(&tuple.elements[0])?, |
There was a problem hiding this comment.
This actually convert the first argument in the tuple to string without validation.
There was a problem hiding this comment.
Ah, that's why the tests are failing.
|
@palaviv I'm not sure if it improves variable lookup but it definitely should improve string-keyed dict lookup, given that it's the exact same string object. I think string interning is the next key feature to make this optimization really take effect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.